lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 15/20] staging: lustre: llite: mark expected switch fall-through
Date

> On Oct 12, 2017, at 10:17, Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Not sure why you moved the "for mode = 0" comment to a separate line?
Not the end of the world though.

Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>

> ---
> drivers/staging/lustre/lustre/llite/namei.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c
> index 5cc2b32..55e0d03 100644
> --- a/drivers/staging/lustre/lustre/llite/namei.c
> +++ b/drivers/staging/lustre/lustre/llite/namei.c
> @@ -949,7 +949,9 @@ static int ll_mknod(struct inode *dir, struct dentry *dchild,
>
> switch (mode & S_IFMT) {
> case 0:
> - mode |= S_IFREG; /* for mode = 0 case, fallthrough */
> + mode |= S_IFREG;
> + /* for mode = 0 case */
> + /* fall through */
> case S_IFREG:
> case S_IFCHR:
> case S_IFBLK:
> --
> 2.7.4
>

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation







\
 
 \ /
  Last update: 2017-10-22 17:05    [W:0.127 / U:0.028 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site