lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 14/20] staging: lustre: lnet: selftest: mark expected switch fall-throughs
Date
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
>
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>

> ---
> drivers/staging/lustre/lnet/selftest/module.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
> index b5d556f..fa1bccc 100644
> --- a/drivers/staging/lustre/lnet/selftest/module.c
> +++ b/drivers/staging/lustre/lnet/selftest/module.c
> @@ -57,10 +57,13 @@ lnet_selftest_exit(void)
> switch (lst_init_step) {
> case LST_INIT_CONSOLE:
> lstcon_console_fini();
> + /* fall through */
> case LST_INIT_FW:
> sfw_shutdown();
> + /* fall through */
> case LST_INIT_RPC:
> srpc_shutdown();
> + /* fall through */
> case LST_INIT_WI_TEST:
> for (i = 0;
> i < cfs_cpt_number(lnet_cpt_table()); i++) {
> @@ -72,7 +75,7 @@ lnet_selftest_exit(void)
> sizeof(lst_sched_test[0]) *
> cfs_cpt_number(lnet_cpt_table()));
> lst_sched_test = NULL;
> -
> + /* fall through */
> case LST_INIT_WI_SERIAL:
> cfs_wi_sched_destroy(lst_sched_serial);
> lst_sched_serial = NULL;
> --
> 2.7.4
>

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation







\
 
 \ /
  Last update: 2017-10-22 17:05    [W:0.153 / U:5.352 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site