Messages in this thread | | | From | "Dilger, Andreas" <> | Subject | Re: [PATCH 05/20] staging: lustre: lnet: net_fault: mark expected switch fall-through | Date | Tue, 17 Oct 2017 22:57:37 +0000 |
| |
On Oct 12, 2017, at 10:16, Gustavo A. R. Silva <garsilva@embeddedor.com> wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
This could also just be "continue;", but doesn't appear harmful.
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> --- > drivers/staging/lustre/lnet/lnet/net_fault.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lnet/lnet/net_fault.c > index 03f3d18..7391e16 100644 > --- a/drivers/staging/lustre/lnet/lnet/net_fault.c > +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c > @@ -629,6 +629,7 @@ delayed_msg_process(struct list_head *msg_list, bool drop) > case LNET_CREDIT_OK: > lnet_ni_recv(ni, msg->msg_private, msg, 0, > 0, msg->msg_len, msg->msg_len); > + /* fall through */ > case LNET_CREDIT_WAIT: > continue; > default: /* failures */ > -- > 2.7.4 >
Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation
| |