Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 01/12] PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags | Date | Tue, 17 Oct 2017 00:05:11 +0200 |
| |
On Monday, October 16, 2017 8:28:52 AM CEST Greg Kroah-Hartman wrote: > On Mon, Oct 16, 2017 at 03:29:02AM +0200, Rafael J. Wysocki wrote: > > struct dev_pm_info { > > pm_message_t power_state; > > unsigned int can_wakeup:1; > > @@ -561,6 +580,7 @@ struct dev_pm_info { > > bool is_late_suspended:1; > > bool early_init:1; /* Owned by the PM core */ > > bool direct_complete:1; /* Owned by the PM core */ > > + unsigned int driver_flags; > > Minor nit, u32 or u64?
u32 I think, will update.
BTW, there's a mess in this struct overall and I'd like all of the bit fileds to be the same type (and that shouldn't be bool IMO :-)).
Do you prefer u32 or unsinged int?
Thanks, Rafael
| |