lkml.org 
[lkml]   [2017]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC][PATCH 00/15] KEYS: Fixes
Date
Eric Biggers <ebiggers3@gmail.com> wrote:

> > - if (test_bit(KEY_FLAG_INSTANTIATED, &key->flags))
> > + if (state == KEY_IS_INSTANTIATED)
> > atomic_dec(&key->user->nikeys);
>
> This changes the behavior. Previously ->nikeys counted both negatively and
> positively instantiated keys, while this change implies that it now will only
> count positively instantiated keys. I think you meant 'state !=
> KEY_IS_UNINSTANTIATED'? Renaming KEY_IS_INSTANTIATED to KEY_IS_POSITIVE or
> KEY_IS_POSITIVELY_INSTANTIATED also might help reduce this confusion.

Yeah - I think I'm confusing myself by overloading 'instantiated' in my mind.

David

\
 
 \ /
  Last update: 2017-10-17 00:10    [W:0.074 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site