lkml.org 
[lkml]   [2017]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] char-TPM: Adjustments for ten function implementations
On Mon, Oct 16, 2017 at 07:30:13PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 16 Oct 2017 19:12:34 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (4):
> Delete an error message for a failed memory allocation
> in tpm_ascii_bios_measurements_show()
> Delete an error message for a failed memory allocation in tpm_ibmvtpm_probe()
> Improve a size determination in nine functions
> Less checks in tpm_ibmvtpm_probe() after error detection
>
> drivers/char/tpm/st33zp24/i2c.c | 3 +--
> drivers/char/tpm/st33zp24/spi.c | 3 +--
> drivers/char/tpm/st33zp24/st33zp24.c | 3 +--
> drivers/char/tpm/tpm1_eventlog.c | 5 +----
> drivers/char/tpm/tpm_crb.c | 2 +-
> drivers/char/tpm/tpm_i2c_atmel.c | 2 +-
> drivers/char/tpm/tpm_i2c_nuvoton.c | 2 +-
> drivers/char/tpm/tpm_ibmvtpm.c | 23 +++++++++--------------
> drivers/char/tpm/tpm_tis.c | 2 +-
> drivers/char/tpm/tpm_tis_spi.c | 3 +--
> 10 files changed, 18 insertions(+), 30 deletions(-)
>
> --
> 2.14.2
>

For some sparse errors I fixed a while ago I got review feedback that
one should explain what is wrong what the fix does and not tell tool
reported. And it really does make sense to me.

Describing the tool that was used to find the issues fits to the cover
letter but not to the commits themselves.

I think I recently accepted a small fix with a "tool generated commit
message" but I don't want to take it as a practice It was a minor
mistake from my side to accept such patch.

/Jarkko

\
 
 \ /
  Last update: 2017-10-16 20:33    [W:0.183 / U:58.336 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site