Messages in this thread | | | Subject | Re: [PATCH] can: check for null sk before deferencing it via the call to sock_net | From | Oliver Hartkopp <> | Date | Mon, 16 Oct 2017 19:32:25 +0200 |
| |
On 10/16/2017 06:37 PM, Josh Boyer wrote: > On Fri, Sep 8, 2017 at 1:46 PM, Oliver Hartkopp <socketcan@hartkopp.net> wrote: >> >> >> On 09/08/2017 05:02 PM, Colin King wrote: >>> >>> From: Colin Ian King <colin.king@canonical.com> >>> >>> The assignment of net via call sock_net will dereference sk. This >>> is performed before a sanity null check on sk, so there could be >>> a potential null dereference on the sock_net call if sk is null. >>> Fix this by assigning net after the sk null check. Also replace >>> the sk == NULL with the more usual !sk idiom. >>> >>> Detected by CoverityScan CID#1431862 ("Dereference before null check") >>> >>> Fixes: 384317ef4187 ("can: network namespace support for CAN_BCM >>> protocol") >>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> >> >> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net> > > I don't see this one queued up in the net or net-next trees. Did it > fall through the cracks or did it get queued up elsewhere? Seems like > it's a good candidate to get into 4.14?
It definitely is!
Marc is our responsible guy for CAN related upstreams - but he seems to be busy as I already poked him here:
https://marc.info/?l=linux-can&m=150771819505097&w=2
If he doesn't send a pull request by beginning of next week, I would ask Dave to grab these patches - to get them into 4.14.
Best regards, Oliver
| |