lkml.org 
[lkml]   [2017]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
From
Date
On Sat, 2017-10-14 at 15:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the first set of initializations. Cleans up the
> clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
[]
> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
[]
> @@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
> u32 i, chain_len, slots_used, max_chain_len;
> struct hashtab_node *cur;
>
> - slots_used = 0;
> - max_chain_len = 0;
> for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
> cur = h->htable[i];
> if (cur) {

I think it'd be nicer if the assignments in the loop
were removed instead.

slots_used = 0;
max_chain_len = 0;
for (i = 0; i < h->size; i++) {
etc...

\
 
 \ /
  Last update: 2017-10-14 17:23    [W:0.033 / U:20.384 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site