lkml.org 
[lkml]   [2017]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] objtool: Print top level commands on incorrect usage
From
Date
On Friday 13 October 2017 10:08 PM, Josh Poimboeuf wrote:
[...]
>> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
>> ---
>> tools/objtool/objtool.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c
>> index 31e0f91..07f3299 100644
>> --- a/tools/objtool/objtool.c
>> +++ b/tools/objtool/objtool.c
>> @@ -70,7 +70,7 @@ static void cmd_usage(void)
>>
>> printf("\n");
>>
>> - exit(1);
>> + exit(129);
>
> For consistency with the rest of the code, this should be -1 instead of
> 129 (though the end result is the same).
>

Thanks for the review. exit(129) is returned by command line parser
when the usage is incorrect, except for cmd_usage(), where the exit
code 1. I will re-send the patch with the better commit message.


--
cheers,
Kamalesh.

\
 
 \ /
  Last update: 2017-10-14 16:39    [W:0.057 / U:6.840 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site