Messages in this thread | | | From | <> | Subject | RE: [PATCH net] net: dsa: mv88e6060: fix switch MAC address | Date | Fri, 13 Oct 2017 19:09:22 +0000 |
| |
> -----Original Message----- > From: netdev-owner@vger.kernel.org [mailto:netdev- > owner@vger.kernel.org] On Behalf Of Vivien Didelot > Sent: Friday, October 13, 2017 1:39 PM > To: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; kernel@savoirfairelinux.com; David S. > Miller; Florian Fainelli; Andrew Lunn; David Laight; Vivien Didelot > Subject: [PATCH net] net: dsa: mv88e6060: fix switch MAC address > > The 88E6060 Ethernet switch always transmits the multicast bit of the > switch MAC address as a zero. It re-uses the corresponding bit 8 of the > register "Switch MAC Address Register Bytes 0 & 1" for "DiffAddr". > > If the "DiffAddr" bit is 0, then all ports transmit the same source > address. If it is set to 1, then bit 2:0 are used for the port number. > > The mv88e6060 driver is currently wrongly shifting the MAC address byte > 0 by 9. To fix this, shift it by 8 as usual and clear its bit 0. > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> > ---
Reviewed-by: Woojung Huh <woojung.huh@microchip.com>
- Woojung
| |