lkml.org 
[lkml]   [2017]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[GIT PULL 05/58] lightnvm: pblk: fix error path in pblk_lines_alloc_metadata
    Date
    From: Rakesh Pandit <rakesh@tuxera.com>

    Use appropriate memory free calls based on allocation type used and
    also fix number of times free is called if kmalloc fails.

    Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
    Reviewed-by: Javier González <javier@cnexlabs.com>
    Signed-off-by: Matias Bjørling <m@bjorling.me>
    ---
    drivers/lightnvm/pblk-init.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
    index 6df65d1..05665a7 100644
    --- a/drivers/lightnvm/pblk-init.c
    +++ b/drivers/lightnvm/pblk-init.c
    @@ -630,7 +630,10 @@ static int pblk_lines_alloc_metadata(struct pblk *pblk)

    fail_free_emeta:
    while (--i >= 0) {
    - vfree(l_mg->eline_meta[i]->buf);
    + if (l_mg->emeta_alloc_type == PBLK_VMALLOC_META)
    + vfree(l_mg->eline_meta[i]->buf);
    + else
    + kfree(l_mg->eline_meta[i]->buf);
    kfree(l_mg->eline_meta[i]);
    }

    --
    2.9.3
    \
     
     \ /
      Last update: 2017-10-13 15:03    [W:6.857 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site