Messages in this thread | | | Date | Fri, 13 Oct 2017 00:06:30 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH] objtool: Fix memory leak in decode_instructions() |
| |
On Fri, Oct 13, 2017 at 10:14:36AM +0530, Kamalesh Babulal wrote: > On Thursday 12 October 2017 09:40 PM, Josh Poimboeuf wrote: > > On Thu, Oct 12, 2017 at 02:32:14PM +0530, Kamalesh Babulal wrote: > > > free the allocated insn before returning, when an error occurs > > > before adding insn to file->insn_list. > > > > > > Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> > > > > Any chance you're working on porting objtool to ppc64le? :-) > > > > Acked-by: Josh Poimboeuf <jpoimboe@redhat.com> > > > > Thanks for the review. I have started working on it :)
Good! Let me know if you have any questions.
I originally wrote objtool with arch-independence in mind, though with the new "objtool 2.0" rewrite, it unfortunately became more x86-specific.
I was hoping to work on making it more arch-independent, and then start porting it to other arches, but it may be a few months before I have the time to do so. So any work you want to there would be great.
-- Josh
| |