Messages in this thread | | | From | "Brown, Aaron F" <> | Subject | RE: [Intel-wired-lan] [PATCH][V3] e1000: avoid null pointer dereference on invalid stat type | Date | Sat, 14 Oct 2017 01:44:02 +0000 |
| |
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf > Of Colin King > Sent: Friday, September 22, 2017 10:14 AM > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; intel-wired- > lan@lists.osuosl.org; netdev@vger.kernel.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH][V3] e1000: avoid null pointer dereference > on invalid stat type > > From: Colin Ian King <colin.king@canonical.com> > > Currently if the stat type is invalid then data[i] is being set > either by dereferencing a null pointer p, or it is reading from > an incorrect previous location if we had a valid stat type > previously. Fix this by skipping over the read of p on an invalid > stat type. > > Detected by CoverityScan, CID#113385 ("Explicit null dereferenced") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
| |