Messages in this thread | | | From | Sean Paul <> | Date | Thu, 12 Oct 2017 10:42:55 -0400 | Subject | Re: [PATCH] drm: Fix return value check in kirin_drm_platform_probe() |
| |
On Thu, Oct 12, 2017 at 2:39 AM, Gabriel Krisman Bertazi <krisman@collabora.co.uk> wrote: > Wei Yongjun <weiyongjun1@huawei.com> writes: > >> In case of error, the function of_graph_get_remote_node() returns NULL >> pointer not ERR_PTR(). The IS_ERR() test in the return value check >> should be replaced with NULL test.. > > Looks good. > > Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> >
FYI, I just noticed Dan Carpenter sent an identical patch last week "<20171005125751.jvtjms62vbtxuvak@mwanda> [PATCH] drm/kirin: Checking for IS_ERR() instead of NULL".
I'll add my R-b there, since it was first.
Sean
> -- > Gabriel Krisman Bertazi
| |