lkml.org 
[lkml]   [2017]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing/xen: Hide events that are not used when X86_PAE is not defined
On Wed, 11 Oct 2017 19:39:20 -0500
Jeremy Linton <jeremy.linton@arm.com> wrote:

> On 10/10/2017 06:12 PM, Steven Rostedt wrote:
> > From: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> > TRACE_EVENTS() take up memory. If they are defined but not used, then
> > they simply waste space. If their use case is behind a define, then the
> > trace events should be as well.
> >
> > The trace events xen_mmu_set_pte_atomic, xen_mmu_pte_clear, and
> > xen_mmu_pmd_clear are not used when CONFIG_X86_PAE is not defined.
>
> The only place i see them being used is mmu_pv.c, where they are wrapped
> in the stated #define.
>
> Looks good.
>
> Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
>

Thanks Jeremy,

-- Steve

\
 
 \ /
  Last update: 2017-10-12 03:06    [W:0.046 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site