Messages in this thread | | | From | <> | Subject | RE: [PATCH v2 net-next 1/2] net: dsa: lan9303: Move tag setup to new lan9303_setup_tagging | Date | Wed, 11 Oct 2017 14:01:57 +0000 |
| |
> >>>> @@ -644,6 +648,10 @@ static int lan9303_setup(struct dsa_switch *ds) > >>>> return -EINVAL; > >>>> } > >>>> > >>>> + ret = lan9303_setup_tagging(chip); > >>>> + if (ret) > >>>> + dev_err(chip->dev, "failed to setup port tagging %d\n", ret); > >>>> + > >>> Still move on when error happens? > >>> > >> Good question. I just followed the pattern from the original function, > >> which was not made by me. Actually I did once reflect on whether this > >> was the correct way. Perhaps it could be argued that it is better to > >> allow the device to come up, so the problem can be investigated? > > Maybe depends on severity of setting? > > BTW, lan9303_setup() still returns ZERO at the end? > I did quick survey of the _setup functions of the other dsa drivers. > Some return on error, some ignore errors. > If you think so, I can make a v3 series that return on error. Otherwise > I leave it as it is.
Unless Andrew, Vivien or Florian raises flag, I guess it will be fine as-is.
Thanks. Woojung
| |