lkml.org 
[lkml]   [2017]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.13 045/160] tipc: use only positive error codes in messages
    Date
    4.13-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>


    [ Upstream commit aad06212d36cf34859428a0a279e5c14ee5c9e26 ]

    In commit e3a77561e7d32 ("tipc: split up function tipc_msg_eval()"),
    we have updated the function tipc_msg_lookup_dest() to set the error
    codes to negative values at destination lookup failures. Thus when
    the function sets the error code to -TIPC_ERR_NO_NAME, its inserted
    into the 4 bit error field of the message header as 0xf instead of
    TIPC_ERR_NO_NAME (1). The value 0xf is an unknown error code.

    In this commit, we set only positive error code.

    Fixes: e3a77561e7d32 ("tipc: split up function tipc_msg_eval()")
    Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/tipc/msg.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/tipc/msg.c
    +++ b/net/tipc/msg.c
    @@ -551,7 +551,7 @@ bool tipc_msg_lookup_dest(struct net *ne
    return false;
    if (msg_errcode(msg))
    return false;
    - *err = -TIPC_ERR_NO_NAME;
    + *err = TIPC_ERR_NO_NAME;
    if (skb_linearize(skb))
    return false;
    msg = buf_msg(skb);

    \
     
     \ /
      Last update: 2017-10-10 22:29    [W:3.694 / U:0.816 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site