lkml.org 
[lkml]   [2017]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.13 130/160] HID: wacom: leds: Dont try to control the EKRs read-only LEDs
    Date
    4.13-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Aaron Armstrong Skomra <skomra@gmail.com>

    commit 74aebed6dc13425233f2224668353cff7a112776 upstream.

    Commit a50aac7193f1 introduces 'led.groups' and adds EKR support
    for these groups. However, unlike the other devices with LEDs,
    the EKR's LEDs are read-only and we shouldn't attempt to control
    them in wacom_led_control().

    See bug: https://sourceforge.net/p/linuxwacom/bugs/342/

    Fixes: a50aac7193f1 ("HID: wacom: leds: dynamically allocate LED groups")
    Signed-off-by: Aaron Armstrong Skomra <aaron.skomra@wacom.com>
    Reviewed-by: Jason Gerecke <jason.gerecke@wacom.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hid/wacom_sys.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/hid/wacom_sys.c
    +++ b/drivers/hid/wacom_sys.c
    @@ -766,6 +766,9 @@ static int wacom_led_control(struct waco
    if (!wacom->led.groups)
    return -ENOTSUPP;

    + if (wacom->wacom_wac.features.type == REMOTE)
    + return -ENOTSUPP;
    +
    if (wacom->wacom_wac.pid) { /* wireless connected */
    report_id = WAC_CMD_WL_LED_CONTROL;
    buf_size = 13;

    \
     
     \ /
      Last update: 2017-10-10 22:16    [W:4.137 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site