Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 1 Oct 2017 11:43:56 +0300 | Subject | Re: [PATCH v3 3/8] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check |
| |
On Sat, Sep 30, 2017 at 4:29 AM, Darren Hart <dvhart@infradead.org> wrote: > On Wed, Sep 27, 2017 at 11:02:15PM -0500, Mario Limonciello wrote: >> The Dell WMI descriptor check is used as an indication that WMI >> calls are safe to run both when used with the notification >> ASL/GUID pair as well as the SMBIOS calling ASL/GUID pair. >> >> As some code in dell-wmi-smbios is already a prerequisite for >> dell-wmi, move the code for performing the descriptor check into >> dell-wmi-smbios and let both drivers use it from there.
>> + if (desc_buffer[0] != 0x4C4C4544 && desc_buffer[1] != 0x494D5720) > > This seems like it should be an || ? > > (I see this is fixed in a later patch)
Interesting, I proposed to use strncmp(), but it's gone again. Perhaps I missed what is downside of that.
-- With Best Regards, Andy Shevchenko
| |