[lkml]   [2017]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 03/13] perf report: create real callchain entries for inlined frames
On Sun, 2017-10-01 at 14:37 +0200, Milian Wolff wrote:
> On Dienstag, 19. September 2017 14:27:11 CEST Jiri Olsa wrote:
> > nit, think we prefer the /* */ comment style
> I'll fix this, but note that there are more places outside this patch series
> where this style has crept in. Some of them also from past patches of mine -
> sorry for that.

I think c99 comments are fine.
So did Linus Torvalds.

> I looks to me as if the should catch this, but it doesn't for me
> which is odd. Does anyone know what I need to do to enable the C99_COMMENTS
> check?

Modify checkpatch

my $allow_c99_comments = 1;

change the 1 to 0

Add a runtime option if you want.

 \ /
  Last update: 2017-10-01 19:41    [W:0.090 / U:7.152 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site