Messages in this thread | | | Date | Mon, 9 Jan 2017 15:18:08 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 2/4] mm: add new mmget() helper |
| |
On Sun, 18 Dec 2016 13:32:27 +0100 Vegard Nossum <vegard.nossum@oracle.com> wrote:
> Apart from adding the helper function itself, the rest of the kernel is > converted mechanically using: > > git grep -l 'atomic_inc.*mm_users' | xargs sed -i 's/atomic_inc(&\(.*\)->mm_users);/mmget\(\1\);/' > git grep -l 'atomic_inc.*mm_users' | xargs sed -i 's/atomic_inc(&\(.*\)\.mm_users);/mmget\(\&\1\);/' > > This is needed for a later patch that hooks into the helper, but might be > a worthwhile cleanup on its own. > > ... >
mmgrap() and mmget() naming is really quite confusing.
> --- a/arch/arc/kernel/smp.c > +++ b/arch/arc/kernel/smp.c > @@ -124,7 +124,7 @@ void start_kernel_secondary(void) > /* MMU, Caches, Vector Table, Interrupts etc */ > setup_processor(); > > - atomic_inc(&mm->mm_users); > + mmget(mm);
I wonder if mmuse() would be a bit clearer than mmget(). Although that sounds like use_mm().
| |