lkml.org 
[lkml]   [2017]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] nbd: blk_mq_init_queue returns an error code on failure, not NULL
On Mon, Jan 9, 2017 at 3:41 PM, Jens Axboe <axboe@kernel.dk> wrote:
> On 01/09/2017 01:27 PM, Omar Sandoval wrote:
>> On Mon, Jan 09, 2017 at 03:20:31PM -0500, Jeff Moyer wrote:
>>> Additionally, don't assign directly to disk->queue, otherwise
>>> blk_put_queue (called via put_disk) will choke (panic) on the errno
>>> stored there.
>>>
>>> Bug found by code inspection after Omar found a similar issue in
>>> virtio_blk. Compile-tested only.
>>>
>>> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
>>
>> Reviewed-by: Omar Sandoval <osandov@fb.com>
>>
>> Compile-reviewed only :) Josef can probably test it if he cares
>> enough,
>> but it looks right.
>
> Looks good to me, too. Josef, you want me to queue this up directly?

Y'all are hilarious.

Reviewed-by: Josef Bacik <jbacik@fb.com>

Thanks,

Josef

\
 
 \ /
  Last update: 2017-01-09 21:45    [W:0.034 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site