[lkml]   [2017]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2
Mon, Jan 09, 2017 at 06:42:07PM CET, wrote:
>On 01/09/2017 08:06 AM, Jiri Pirko wrote:
>> Mon, Jan 09, 2017 at 04:45:33PM CET, wrote:
>>> Hi Jiri,
>>> Jiri Pirko <> writes:
>>>>> Extra question: shouldn't phys_port_{id,name} be switchdev attributes in
>>>> Again, phys_port_id has nothing to do with switches. Should be removed
>>>> from dsa because its use there is incorrect.
>>> Florian, since 3a543ef just got in, can it be reverted?
>> Yes, please revert it. It is only in net-next.
>Maybe the use case can be understood before reverting the change. How do
>we actually the physical port number of an Ethernet switch per-port
>network device? The name is not enough, because there are plenty of
>cases where we need to manipulate a physical port number (be it just for
>informational purposes).

Like what?

Why the name is not enough? This is something propagated to userspace
and never used internally in kernel.

Btw, ndo_get_phys_port_id does not give you number, but arbitrary binary.

>Should we just amend the existing description of ndo_get_phys_port_id()?
>Should we introduce another ndo for that?

 \ /
  Last update: 2017-01-09 19:00    [W:0.081 / U:4.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site