lkml.org 
[lkml]   [2017]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V5 04/17] blk-throttle: configure bps/iops limit for cgroup in low limit
Hello,

On Thu, Dec 15, 2016 at 12:32:55PM -0800, Shaohua Li wrote:
> each queue will have a state machine. Initially queue is in LIMIT_LOW
> state, which means all cgroups will be throttled according to their low
> limit. After all cgroups with low limit cross the limit, the queue state
> gets upgraded to LIMIT_MAX state.

As with the previous patch, I don't think it's correct to default to
MAX for LIMIT_LOW and then enforce it. Without specific
configuration, a cgroup should always be above below (so, no latency
requirement) and below max (no hard limiting).

Thanks.

--
tejun

\
 
 \ /
  Last update: 2017-01-09 18:35    [W:0.217 / U:2.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site