lkml.org 
[lkml]   [2017]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths
On Sat, 7 Jan 2017, Krzysztof Kozlowski wrote:

> Returning from for_each_available_child_of_node() loop requires cleaning
> up node refcount. Error paths lacked it so for example in case of
> deferred probe, the refcount of phy node was left increased.
>
> Fixes: 6d40500ac9b6 ("usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/usb/host/ehci-exynos.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
> index 42e5b66353ef..7a603f66a9bc 100644
> --- a/drivers/usb/host/ehci-exynos.c
> +++ b/drivers/usb/host/ehci-exynos.c
> @@ -77,10 +77,12 @@ static int exynos_ehci_get_phy(struct device *dev,
> if (IS_ERR(phy)) {
> ret = PTR_ERR(phy);
> if (ret == -EPROBE_DEFER) {
> + of_node_put(child);
> return ret;
> } else if (ret != -ENOSYS && ret != -ENODEV) {
> dev_err(dev,
> "Error retrieving usb2 phy: %d\n", ret);
> + of_node_put(child);
> return ret;
> }
> }
>

Acked-by: Alan Stern <stern@rowland.harvard.edu>

\
 
 \ /
  Last update: 2017-01-09 17:06    [W:0.063 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site