lkml.org 
[lkml]   [2017]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: drivers/net/wireless/intel/iwlwifi/pcie/trans.c: 2 * suspicious code ?
On Fri, 2017-01-06 at 17:47 +0000, David Binderman wrote:
> Hello there,

Hi David,


> 1.
>
> drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2039:14: warning: decrement of a boolean expression [-Wbool-operation]
>
> Source code is
>
> txq->block--;
>
> Maybe someone got a bool and a int mixed up ?
>
> 2.
>
> drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2045:14: warning: increment of a boolean expression [-Wbool-operation]
>
> Duplicate a few lines further down.

Emmanuel has fixed this in our internal tree and I'll be sending it out
together with our normal upstreaming process.

Thanks for reporting!

--
Cheers,
Luca.

\
 
 \ /
  Last update: 2017-01-09 12:18    [W:0.023 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site