Messages in this thread | | | Date | Sun, 8 Jan 2017 17:38:31 +0000 | From | Andrey Utkin <> | Subject | Re: [PATCH] solo6x10: use designated initializers |
| |
On Fri, Jan 06, 2017 at 01:21:10PM -0800, Kees Cook wrote: > > Since `ops` is static, what about this? > > For the variant given below, you have my signoff. > > > >> --- a/drivers/media/pci/solo6x10/solo6x10-g723.c > >> +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c > >> @@ -350,7 +350,7 @@ static int solo_snd_pcm_init(struct solo_dev *solo_dev) > >> > >> int solo_g723_init(struct solo_dev *solo_dev) > >> { > >> - static struct snd_device_ops ops = { NULL }; > >> + static struct snd_device_ops ops; > > Ah! Yes, thanks. That works fine too. :) Can this be const as well?
No, it can't be const, it's used as parameter for snd_device_new() which takes "struct snd_device_ops *".
| |