lkml.org 
[lkml]   [2017]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 085/116] IB/cma: Fix a race condition in iboe_addr_get_sgid()
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Bart Van Assche <bart.vanassche@sandisk.com>

    commit fba332b079029c2f4f7e84c1c1cd8e3867310c90 upstream.

    Code that dereferences the struct net_device ip_ptr member must be
    protected with an in_dev_get() / in_dev_put() pair. Hence insert
    calls to these functions.

    Fixes: commit 7b85627b9f02 ("IB/cma: IBoE (RoCE) IP-based GID addressing")
    Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
    Reviewed-by: Moni Shoua <monis@mellanox.com>
    Cc: Or Gerlitz <ogerlitz@mellanox.com>
    Cc: Roland Dreier <roland@purestorage.com>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    include/rdma/ib_addr.h | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/include/rdma/ib_addr.h
    +++ b/include/rdma/ib_addr.h
    @@ -205,10 +205,12 @@ static inline void iboe_addr_get_sgid(st

    dev = dev_get_by_index(&init_net, dev_addr->bound_dev_if);
    if (dev) {
    - ip4 = (struct in_device *)dev->ip_ptr;
    - if (ip4 && ip4->ifa_list && ip4->ifa_list->ifa_address)
    + ip4 = in_dev_get(dev);
    + if (ip4 && ip4->ifa_list && ip4->ifa_list->ifa_address) {
    ipv6_addr_set_v4mapped(ip4->ifa_list->ifa_address,
    (struct in6_addr *)gid);
    + in_dev_put(ip4);
    + }
    dev_put(dev);
    }
    }

    \
     
     \ /
      Last update: 2017-01-06 23:34    [W:4.677 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site