Messages in this thread | | | Date | Fri, 6 Jan 2017 11:56:11 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch |
| |
On Fri, Jan 06, 2017 at 12:14:13AM +0000, Junichi Nomura wrote: > Personally I have same opinion as yours. :) > > But according to Documentation/process/coding-style.rst, it seems > "sizeof(*p)" is preferred style and the reason there makes some > sense. > > Quote from coding-style.rst: > > The preferred form for passing a size of a struct is the following: > > > > p = kmalloc(sizeof(*p), ...); > > > > The alternative form where struct name is spelled out hurts readability and ^^^^^^^^^^^^^^^^^^^^^
Yeah, right. Change is from 2005 (af4e5a218e18a). Pekka didn't know better then. :-P
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |