Messages in this thread | | | Date | Fri, 6 Jan 2017 01:00:00 -0800 | From | Jiada Wang <> | Subject | Re: [PATCH 1/1] spi: imx: support to set watermark level via DTS |
| |
Hello Mark and Vladimir
On 01/05/2017 09:58 AM, Mark Brown wrote: > On Thu, Jan 05, 2017 at 03:10:15PM +0900, Jiada Wang wrote: > >> Previously watermark level is configured to fifosize/2, >> DMA mode can be used only when transfer length can be divided >> by 'watermark level * bpw', which makes DMA mode not practical. >> This patch adds new DTS property 'dma-wml', user can configure >> DMA watermark level, by specify 'dma-wml' in corresponding ecspi >> node. > Doesn't this just move the problem around a bit - can we not have the > driver figure out a more sensible watermark for each transfer rather > than fixing one in the DT? I would like to submit another version of patch to adjust watermark level based on transfer length. to use largest number (< fifosize / 2 ) which can divide (transfer_length / bytes_per_work).
Thanks, Jiada
| |