Messages in this thread | | | From | Daniel Stone <> | Date | Wed, 4 Jan 2017 17:02:57 +0000 | Subject | Re: [PATCH v2 1/2] drm_fourcc: Add new P010, P016 video format |
| |
Hi Randy,
On 4 January 2017 at 16:29, Randy Li <ayaka@soulik.info> wrote: > index 90d2cc8..23c8e99 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -165,6 +165,9 @@ const struct drm_format_info *__drm_format_info(u32 format) > { .format = DRM_FORMAT_UYVY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > { .format = DRM_FORMAT_VYUY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > { .format = DRM_FORMAT_AYUV, .depth = 0, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1 }, > + /* FIXME a pixel in Y for P010 is 10 bits */ > + { .format = DRM_FORMAT_P010, .depth = 0, .num_planes = 2, .cpp = { 1, 2, 0 }, .hsub = 2, .vsub = 2 },
It seems like P010 stores each Y component in a 16-bit value, with the bottom 6 bits ignored. So I think cpp here should be 2.
Cheers, Daniel
| |