Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 4 Jan 2017 11:18:14 +0100 | Subject | Re: [PATCH PoCv2 0/2] mmc: add blk-mq support |
| |
On Tue, Jan 3, 2017 at 6:30 PM, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote:
Interesting patch!
> The differences between these patches and Linus' RFD patch: > - request completion is handled from the IRQ handler > (or tasklet context as happens in dw_mmc host driver)
I think we need to make a patch like this separately to the current (only old blk) code, to stop the kthread from forcing in NULL requests to clean the pipeline.
We should also avoid sending any completion at all: if we know we only get one request at a time as your patch does, there is no reason to wait for a completion: we will always be complete when a new request arrives.
Same with two requests in parallel, we can trust the block layer to not send more than 2 (the queue depth) so there is no reason to wait for a completion.
I'm trying to work in this direction at least, your patch is great inspiration!
Yours, Linus Walleij
| |