lkml.org 
[lkml]   [2017]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCHv2 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs
    From
    Date
    Le 01/04/17 à 19:36, Chris Packham a écrit :
    > The Marvell 98DX3236, 98DX3336, 98DX4521 and variants are switch ASICs
    > with integrated CPUs. They are similar to the Armada XP SoCs but have
    > different I/O interfaces.
    >
    > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
    > ---
    > +
    > + switch {
    > + packet-processor@0 {
    > + compatible = "marvell,prestera-98dx4521";
    > + };
    > + };

    This may be a bit premature if you are not providing a binding document
    for this sub-node, you might as well add it once you also add a
    corresponding driver (or if this will remain out of tree, at least
    submitting a separate binding document).

    Also, if this node's unit address is 0, you would expect at least a reg
    property whose address cell is 0 to be present.
    --
    Florian

    \
     
     \ /
      Last update: 2017-01-05 05:10    [W:3.629 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site