Messages in this thread | | | Subject | Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy | From | Jaehoon Chung <> | Date | Thu, 05 Jan 2017 11:22:17 +0900 |
| |
On 01/05/2017 02:52 AM, Krzysztof Kozlowski wrote: > On Wed, Jan 04, 2017 at 09:34:32PM +0900, Jaehoon Chung wrote: >> This patch supports to use Generic Phy framework for Exynos PCIe phy. >> When Exynos that supported the pcie want to use the PCIe, >> it needs to control the phy resgister. >> But it should be more complex to control in their own PCIe device drivers. >> >> Currently, there is an exynos5440 case to support the pcie. >> So this driver is based on Exynos5440 PCIe. >> In future, will support the Other exynos SoCs likes exynos5433, exynos7. > > I have troubles understanding this. Please, work on the commit message. > > For the code itself: > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > ... but commit message is really important to understand why/what was > done.
Will update the commit-msg. Thanks for comments.
Best Regards, Jaehoon Chung
> > Best regards, > Krzysztof > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >
| |