Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 5 Jan 2017 00:52:05 +0200 | Subject | Re: [PATCH] serial: 8250_lpss: Release Quark MSI vectors on exit |
| |
On Thu, Jan 5, 2017 at 12:46 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 2017-01-04 23:19, Andy Shevchenko wrote: >> On Wed, Jan 4, 2017 at 9:36 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>> No one seems to do this magically in the background, so we have to do >>> the job in the exit handler that corresponds to the board setup handler. >>> >>> Fixes: 60a9244a5d14 ("serial: 8250_lpss: enable MSI for Intel Quark") >>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> >> >> NAK, check the PCI devres code, please. >> >> Christoph, can you amend documentation to make this clear? >> >> I NAKed already third patch related to PCI managed resources (couple >> of those regarding to pci_irq_* API)/ >> > > Ah, there are resources that are managed without being allocated > explicitly that way. Hmm, not very intuitive. Are MSI / MSI-X vectors > the only such cases?
pci_request_regions(), etc. Almost all stuff which is usually used in ->probe() of casual PCI driver.
-- With Best Regards, Andy Shevchenko
| |