lkml.org 
[lkml]   [2017]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/2] fs: configfs: use hexadecimal values and new line
    Date
    Other unsigned properties return hexadecimal values, follow this
    convention when printing b_vendor_code too. Also add newlines to
    the OS Descriptor support related properties, like other sysfs
    files use.

    Signed-off-by: Stefan Agner <stefan@agner.ch>
    ---
    drivers/usb/gadget/configfs.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
    index ea1a40f5b23d..8e9adcfff748 100644
    --- a/drivers/usb/gadget/configfs.c
    +++ b/drivers/usb/gadget/configfs.c
    @@ -737,7 +737,7 @@ static inline struct gadget_info *os_desc_item_to_gadget_info(

    static ssize_t os_desc_use_show(struct config_item *item, char *page)
    {
    - return sprintf(page, "%d",
    + return sprintf(page, "%d\n",
    os_desc_item_to_gadget_info(item)->use_os_desc);
    }

    @@ -761,7 +761,7 @@ static ssize_t os_desc_use_store(struct config_item *item, const char *page,

    static ssize_t os_desc_b_vendor_code_show(struct config_item *item, char *page)
    {
    - return sprintf(page, "%d",
    + return sprintf(page, "0x%02x\n",
    os_desc_item_to_gadget_info(item)->b_vendor_code);
    }

    @@ -903,7 +903,7 @@ static inline struct usb_os_desc_ext_prop

    static ssize_t ext_prop_type_show(struct config_item *item, char *page)
    {
    - return sprintf(page, "%d", to_usb_os_desc_ext_prop(item)->type);
    + return sprintf(page, "%d\n", to_usb_os_desc_ext_prop(item)->type);
    }

    static ssize_t ext_prop_type_store(struct config_item *item,
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-02-01 03:19    [W:2.427 / U:0.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site