lkml.org 
[lkml]   [2017]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop
    Hi Benjamin,

    On Tue, Dec 13, 2016 at 2:16 AM, Benjamin Tissoires
    <benjamin.tissoires@redhat.com> wrote:
    > On Dec 12 2016 or thereabouts, Chris Chiu wrote:
    >> ROG means ASUS "Republic of Gamers" laptops. The input device info
    >> also represents itself as "ASASTeK COMPUTER INC. ROG MacroKey". It
    >> uses special HID_USAGE code for function keys. This commit remap the
    >> special code to standard keycode for function keys handling. It's
    >> verified on GL553VD/VE, GL753VD/VE.
    >>
    >> Signed-off-by: Chris Chiu <chiu@endlessm.com>
    >> Reported-by: Yukai Li <yukaili@gmail.com>
    >> ---
    >
    > Hi Chris,
    >
    > there is no real point of having a separate driver from hid-asus. The
    > HID tree prefer to group drivers by vendors, so these keyboards should
    > be supported through hid-asus.

    Thanks for the feedback. We will submit a new version soon.

    Just to confirm, hid-asus currently depends on I2C_HID. The new
    devices being quirked now are USB devices. With this patch should we
    now update it to depend on I2C_HID && USB_HID?

    Daniel

    \
     
     \ /
      Last update: 2017-01-31 20:43    [W:5.174 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site