lkml.org 
[lkml]   [2017]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V6 1/5] LIB: Indirect ISA/LPC port IO introduced
From
Date
On 31/01/2017 00:09, Bjorn Helgaas wrote:
> On Tue, Jan 24, 2017 at 03:05:21PM +0800, zhichang.yuan wrote:
>> Low-pin-count interface is integrated into some SoCs. The accesses to those
>> peripherals under LPC make use of I/O ports rather than the memory mapped I/O.
>>
>> To drive these devices, this patch introduces a method named indirect-IO.
>
> It's slightly confusing to call this "indirect I/O" and then use
> "extio" for the filename and function prefix. It'd be nice to use
> related names.

We will consider something more consistent.

>
>> +struct extio_node {
>> + unsigned long bus_start; /* bus start address */
>> + unsigned long io_start; /* io port token corresponding to bus_start */
>> + size_t range_size; /* size of the extio node operating range */
>> + struct fwnode_handle *fwnode;
>> + struct list_head list;
>> + struct extio_ops *ops; /* ops operating on this node */
>> + void *devpara; /* private parameter of the host device */
>> +};
>
> I wish we didn't have both struct io_range and struct extio_node. It
> seems like they're both sort of trying to do the same thing. Maybe
> this is the same as what Alex is saying.
>

I think so. I have just replied to Alex regarding this.

> Bjorn
>

Thanks,
John

> .
>


\
 
 \ /
  Last update: 2017-01-31 14:41    [W:0.085 / U:2.828 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site