Messages in this thread | | | From | Inki Dae <> | Date | Tue, 31 Jan 2017 19:37:01 +0900 | Subject | Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board |
| |
2017-01-31 19:01 GMT+09:00 Krzysztof Kozlowski <krzk@kernel.org>: > On Tue, Jan 31, 2017 at 11:34 AM, Inki Dae <inki.dae@samsung.com> wrote: >> >> >> 2017년 01월 31일 18:22에 Krzysztof Kozlowski 이(가) 쓴 글: >>> On Tue, Jan 31, 2017 at 2:01 AM, Inki Dae <inki.dae@samsung.com> wrote: >>>> >>>> >>>> 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: >>>>> Dear Thierry, >>>>> >>>>> Could you please review this patch? >>>> >>>> Thierry, I think this patch has been reviewed enough but no comment from you. Seems you are busy. I will pick up this. >>>> >>> >>> Comments from v8 were not resolved and I think we are waiting for v9: >>> https://lkml.org/lkml/2017/1/11/178 >>> >>> If that is not correct then please clarify. >> >> Seems you pointed to change te-gpios bindings to optional. right? >> >> I thought Rob left ack so it's no problem. >> https://lkml.org/lkml/2017/1/13/626 > > Yes, change them to optional. I think it is a problem (regardless of > Rob's ack) because you are merging a driver requiring a property which > soon you want to remove. If you merge it (like this) removal of > te-gpios property will be breakage of ABI. This is not a serious > problem but knowing such plan of te-gpios removal upfront, it would be > wrong to commit such driver.
This is a trivial thing so it doesn't make breakage of ABI because the property, te-gpios, is *optional*.
Anyway, this wouldn't be *the things* Thierry mentioned.
Thanks, Inki Dae
> > Best regards, > Krzysztof > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |