lkml.org 
[lkml]   [2017]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/17] net: stmmac: fix some code style problem
    Date
    Checkpatch complains about some code style problem on stmmac_mdio.c.
    This patch fix them.

    Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
    ---
    drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
    index 3fdc6ec..c24bef2 100644
    --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
    +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
    @@ -152,9 +152,9 @@ int stmmac_mdio_reset(struct mii_bus *bus)

    #ifdef CONFIG_OF
    if (priv->device->of_node) {
    -
    if (data->reset_gpio < 0) {
    struct device_node *np = priv->device->of_node;
    +
    if (!np)
    return 0;

    @@ -221,7 +221,7 @@ int stmmac_mdio_register(struct net_device *ndev)
    return 0;

    new_bus = mdiobus_alloc();
    - if (new_bus == NULL)
    + if (!new_bus)
    return -ENOMEM;

    if (mdio_bus_data->irqs)
    @@ -258,6 +258,7 @@ int stmmac_mdio_register(struct net_device *ndev)
    found = 0;
    for (addr = 0; addr < PHY_MAX_ADDR; addr++) {
    struct phy_device *phydev = mdiobus_get_phy(new_bus, addr);
    +
    if (phydev) {
    int act = 0;
    char irq_num[4];
    @@ -267,7 +268,7 @@ int stmmac_mdio_register(struct net_device *ndev)
    * If an IRQ was provided to be assigned after
    * the bus probe, do it here.
    */
    - if ((mdio_bus_data->irqs == NULL) &&
    + if ((!mdio_bus_data->irqs) &&
    (mdio_bus_data->probed_phy_irq > 0)) {
    new_bus->irq[addr] =
    mdio_bus_data->probed_phy_irq;
    --
    2.10.2
    \
     
     \ /
      Last update: 2017-01-31 10:46    [W:5.142 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site