Messages in this thread Patch in this message | | | From | Randy Dunlap <> | Subject | [PATCH -next] platform: x86: fix silead_dmi build error and depends | Date | Mon, 30 Jan 2017 16:44:17 -0800 |
| |
From: Randy Dunlap <rdunlap@infradead.org>
This driver cannot be built as a loadable module, so it should not be built unless I2C=y and INPUT=y.
Fixes this build error: drivers/built-in.o: In function `silead_ts_dmi_init': silead_dmi.c:(.init.text+0xf00e): undefined reference to `i2c_bus_type'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Hans de Goede <hdegoede@redhat.com> --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I don't see why the "depends on INPUT" was there at all, but I modified its requirement anyway. Maybe it can be removed...
--- linux-next-20170130.orig/drivers/platform/x86/Kconfig +++ linux-next-20170130/drivers/platform/x86/Kconfig @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 config SILEAD_DMI bool "Tablets with Silead touchscreens" - depends on ACPI && DMI && I2C && INPUT + depends on ACPI && DMI && I2C=y && INPUT=y ---help--- Certain ACPI based tablets with Silead touchscreens do not have enough data in ACPI tables for the touchscreen driver to handle
| |