lkml.org 
[lkml]   [2017]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 8/9] bcache: use kvmalloc
    From
    Date
    On 01/30/2017 10:49 AM, Michal Hocko wrote:
    > From: Michal Hocko <mhocko@suse.com>
    >
    > bcache_device_init uses kmalloc for small requests and vmalloc for those
    > which are larger than 64 pages. This alone is a strange criterion.
    > Moreover kmalloc can fallback to vmalloc on the failure. Let's simply
    > use kvmalloc instead as it knows how to handle the fallback properly

    I don't see why separate patch, some of the conversions in 5/9 were quite
    similar (except comparing with PAGE_SIZE, not 64*PAGE_SIZE), but nevermind.

    > Cc: Kent Overstreet <kent.overstreet@gmail.com>
    > Signed-off-by: Michal Hocko <mhocko@suse.com>

    Acked-by: Vlastimil Babka <vbabka@suse.cz>

    > ---
    > drivers/md/bcache/super.c | 8 ++------
    > 1 file changed, 2 insertions(+), 6 deletions(-)
    >
    > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
    > index 3a19cbc8b230..4cb6b88a1465 100644
    > --- a/drivers/md/bcache/super.c
    > +++ b/drivers/md/bcache/super.c
    > @@ -767,16 +767,12 @@ static int bcache_device_init(struct bcache_device *d, unsigned block_size,
    > }
    >
    > n = d->nr_stripes * sizeof(atomic_t);
    > - d->stripe_sectors_dirty = n < PAGE_SIZE << 6
    > - ? kzalloc(n, GFP_KERNEL)
    > - : vzalloc(n);
    > + d->stripe_sectors_dirty = kvzalloc(n, GFP_KERNEL);
    > if (!d->stripe_sectors_dirty)
    > return -ENOMEM;
    >
    > n = BITS_TO_LONGS(d->nr_stripes) * sizeof(unsigned long);
    > - d->full_dirty_stripes = n < PAGE_SIZE << 6
    > - ? kzalloc(n, GFP_KERNEL)
    > - : vzalloc(n);
    > + d->full_dirty_stripes = kvzalloc(n, GFP_KERNEL);
    > if (!d->full_dirty_stripes)
    > return -ENOMEM;
    >
    >

    \
     
     \ /
      Last update: 2017-01-30 17:51    [W:4.171 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site