Messages in this thread | | | Subject | Re: [PATCH 2/2] perf evsel: Check for NULL before perf_evsel__is_bpf_output() | From | Taeung Song <> | Date | Mon, 30 Jan 2017 19:26:30 +0900 |
| |
Hi, jirka :)
Thank you! Taeung
On 01/30/2017 05:55 PM, Jiri Olsa wrote: > On Mon, Jan 30, 2017 at 02:23:39PM +0900, Taeung Song wrote: >> If 'evsel' is NULL, in perf_evsel__is_bpf_output() >> NULL pointer error can happen so check it. >> >> Cc: Jiri Olsa <jolsa@redhat.com> >> Cc: Namhyung Kim <namhyung@kernel.org> >> Signed-off-by: Taeung Song <treeze.taeung@gmail.com> >> --- >> tools/perf/util/evsel.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c >> index 04e536a..b77da72 100644 >> --- a/tools/perf/util/evsel.c >> +++ b/tools/perf/util/evsel.c >> @@ -242,8 +242,10 @@ struct perf_evsel *perf_evsel__new_idx(struct perf_event_attr *attr, int idx) >> { >> struct perf_evsel *evsel = zalloc(perf_evsel__object.size); >> >> - if (evsel != NULL) >> - perf_evsel__init(evsel, attr, idx); >> + if (!evsel) >> + return NULL; >> + >> + perf_evsel__init(evsel, attr, idx); > > Acked-by: Jiri Olsa <jolsa@kernel.org> > > thanks, > jirka >
| |