lkml.org 
[lkml]   [2017]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Subject: [PATCH v1] USB:Core: BugFix: Proper handling of Race Condition when two USB class drivers try to call init_usb_class simultaneously
On Mon, Jan 30, 2017 at 08:25:25AM +0000, Ajay Kaher wrote:
>

First off, you are sending html email, which the mailing list keeps
rejecting, why are you ignoring that?



>
> There is race condition when two USB class drivers try to call
>
> init_usb_class at the same time and leads to crash.
>
>
>
> The main reason for this is one of the Class drivers allocates memory
> for usb_class structure and initializes its member. In the meantime NULL
> check for usb_class structure fails and assumes that usb_class structure
> is properly initialized and crashed while trying to access its members.
>
>
>
> To avoid this race condition locking required before calling
> init_usb_class from function usb_register_dev.
>
>
>
>
>
> Signed-off-by: Ajay Kaher

Does this look correct? Please work with some of the samsung kernel
developers for how to properly submit a patch.

And finally, how are two drivers calling init_usb_class() at the same
time? What code path causes that? Have you seen this happen, and if
so, what drivers caused it?

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-01-30 11:32    [W:0.044 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site