Messages in this thread | | | Date | Tue, 3 Jan 2017 15:39:46 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/4] perf, tools: Add probing for xed |
| |
Em Tue, Jan 03, 2017 at 07:11:06AM -0800, Andi Kleen escreveu: > > please don't put it in FEATURE_DISPLAY.. AFAICS there's not any xed > > package yet, just the sources, so the "xed: OFF" build message would > > bother almost everyone probably for long time.. > > It should be eventually packaged. How would people know they are missing > it without displaying it? I think it has to, otherwise most people will > miss out on the feature. Silent failure is bad.
Right, you have a point, we should have some warning to the user for when features are not being automatically probed for, i.e. extra features may be enabled using special command line settings, read the docs to see how.
- Arnaldo
| |