Messages in this thread | | | Subject | Re: [PATCH v9 6/8] drivers:input:ads7846(+tsc2046): fix spi module table | From | "H. Nikolaus Schaller" <> | Date | Sun, 29 Jan 2017 09:39:39 +0100 |
| |
Hi Dmitry,
> Am 28.01.2017 um 20:35 schrieb Dmitry Torokhov <dmitry.torokhov@gmail.com>: > > On Wed, Dec 28, 2016 at 03:53:21PM +0100, H. Nikolaus Schaller wrote: >> Fix module table so that the driver is loaded if compiled >> as module and requested by DT. >> > > I believe I already replied to a similar patch: we alreadyhave necessary > aliases in this driver, we need to fix module loading to use it.
Yes, you did comment on [PATCH v6 7/8] (19 Nov 2016):
>> We really need to fix it between spi/i23c core and module utils instead >> of keeping adding duplicate IDs all over drivers. We already have OF >> module device table containing the same data, we should be able to use >> it.
And Javier Martinez Canillas replied (23 Nov 2016):
> Agreed, unfortunately until the I2C and SPI core are changed to properly > report OF modaliases, we will have to keep adding these duplicated IDs. > > And changing the I2C and SPI core isn't trivial since it could break a > lot of drivers that rely on a platform modalias being reported (i.e: no > OF device IDs present in the drivers even when are registered via DT).
Therefore I didn't see a need to change it.
BR, Nikolaus
| |