Messages in this thread | | | Date | Sun, 29 Jan 2017 23:56:38 +0000 (GMT) | From | James Simmons <> | Subject | Re: [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs to proper structure |
| |
> On Sat, 2017-01-21 at 19:40 -0500, James Simmons wrote: > > The upstream kernel requires proper structures so > > convert nearly all the LNet wire protocols typedefs in > > the LNet core. > > Thanks. > > Perhaps s/\bWIRE_ATTR\b/__packed/g one day too
I liked to keep that one. The point of WIRE_ATTR isn't to be some abstraction but to label that struct as something that goes over the wire. This lets people know that it would break something if you change that structure. Looks like I need to send a patch that adds a comment explaning the meaning of WIRE_ATTR.
| |