lkml.org 
[lkml]   [2017]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i2c: piix4: Fix request_region size
Hi Wolfram,

On Sat, 28 Jan 2017 12:00:21 +0100, Wolfram Sang wrote:
>
> > >  /* count for request_region */
> > > -#define SMBIOSIZE 8
> > > +#define SMBIOSIZE 9
> >
> > Are you certain that all supported devices have this extra register?
>
> Isn't it better to have a potentially unused register mapped than a
> potentially used register unmapped?

My concern is that the region request could fail due to a conflict with
another device, if the physical I/O region is only 8 and we try to
request 9.

--
Jean Delvare
SUSE L3 Support

\
 
 \ /
  Last update: 2017-01-28 12:15    [W:0.056 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site