lkml.org 
[lkml]   [2017]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 22/50] x86/boot/e820: Convert printk(KERN_* ...) to pr_*()
From
Date
On Sat, 2017-01-28 at 23:11 +0100, Ingo Molnar wrote:
> No change in functionality.

Not true.

> @@ -419,11 +419,11 @@ __e820_update_range(struct e820_table *table, u64 start, u64 size, unsigned old_
> size = ULLONG_MAX - start;
>
> end = start + size;
> - printk(KERN_DEBUG "e820: update [mem %#010Lx-%#010Lx] ", start, end - 1);
> + pr_debug("e820: update [mem %#010Lx-%#010Lx] ", start, end - 1);

#define DEBUG is not set here so this conversion is
not equivalent.

pr_debug will be removed unless CONFIG_DYNAMIC_DEBUG
is enabled and also will not be enabled by default.

> e820_print_type(old_type);
> - printk(KERN_CONT " ==> ");
> + pr_cont(" ==> ");

This will always be emitted.

> @@ -495,10 +495,10 @@ u64 __init e820_remove_range(u64 start, u64 size, unsigned old_type, int checkty
> size = ULLONG_MAX - start;
>
> end = start + size;
> - printk(KERN_DEBUG "e820: remove [mem %#010Lx-%#010Lx] ", start, end - 1);
> + pr_debug("e820: remove [mem %#010Lx-%#010Lx] ", start,

etc...

\
 
 \ /
  Last update: 2017-01-29 00:26    [W:0.204 / U:2.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site