Messages in this thread | | | Date | Fri, 27 Jan 2017 21:00:12 +0300 | From | Vladimir Davydov <> | Subject | Re: [PATCH v2 02/10] slub: separate out sysfs_slab_release() from sysfs_slab_remove() |
| |
On Mon, Jan 23, 2017 at 05:54:49PM -0500, Tejun Heo wrote: > From 3b0cdd93b2d9bdea62ea6681e612bdae7a40d883 Mon Sep 17 00:00:00 2001 > From: Tejun Heo <tj@kernel.org> > Date: Mon, 23 Jan 2017 17:53:18 -0500 > > Separate out slub sysfs removal and release, and call the former > earlier from __kmem_cache_shutdown(). There's no reason to defer > sysfs removal through RCU and this will later allow us to remove sysfs > files way earlier during memory cgroup offline instead of release. > > v2: Add slab_state >= FULL test to sysfs_slab_release() so that > kobject_put() is skipped for caches which aren't fully initialized > as before. This most likely leaks the kmem_cache on init failure > as we're skipping the only release path. Let's fix that up later. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Vladimir Davydov <vdavydov.dev@gmail.com> > Cc: Christoph Lameter <cl@linux.com> > Cc: Pekka Enberg <penberg@kernel.org> > Cc: David Rientjes <rientjes@google.com> > Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> > Cc: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Vladimir Davydov <vdavydov.dev@gmail.com>
| |